Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for assuming IAM roles #12

Merged
merged 1 commit into from
Jan 13, 2017
Merged

Conversation

mattstep
Copy link
Contributor

@mattstep mattstep commented Jan 4, 2017

@reviewbybees

@recampbell
Copy link
Member

@stephenc Do you mind taking a peek for any issues here?

@stephenc
Copy link
Member

stephenc commented Jan 5, 2017

🐝 from the 😎 on a 🏇

@mattstep
Copy link
Contributor Author

mattstep commented Jan 5, 2017

@stephenc you ride? Awesome, thanks!

@stephenc
Copy link
Member

stephenc commented Jan 5, 2017

@mattstep often reviews are from the proverbial "blind person on a galloping horse"... 😎 on a 🏇 is the emoji equivalent

@mattstep
Copy link
Contributor Author

mattstep commented Jan 5, 2017

@stephenc Ah, gotcha!

@ghost
Copy link

ghost commented Jan 11, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@mattstep
Copy link
Contributor Author

mattstep commented Jan 11, 2017

@recampbell or @stephenc can either of you merge this for me? It meets the requirements of reviewbybees I believe... I don't have permission to merge into this repo.

@andresrc andresrc merged commit 4e080eb into jenkinsci:master Jan 13, 2017
@cristim
Copy link

cristim commented May 16, 2017

How are these roles exposed to Jenkins?

In my setup the plugin only defines the access key and secret variables and fails to expose the temporary token to the Jenkins job, which fails to run.

@recena
Copy link

recena commented Jun 3, 2017

Changes without a JIRA issue associated... 😢

@farrellit
Copy link

I don't understand either. It says it "supports roles" but there doesn't seem to be any way to get the session token. What a waste of time this plugin has turned into for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants