Correcting default credentials when using assumed roles #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
added a commit
to jglick/pipeline-cloudwatch-logs-plugin
that referenced
this pull request
Oct 16, 2018
Merged
8 tasks
oleg-nenashev
approved these changes
Nov 9, 2018
There was a problem hiding this comment.
LGTM, not sure who is the current maintainer.
@andresrc are you still interested in it?
| @@ -156,7 +161,7 @@ public String getDisplayName() { | |||
| return accessKey + ":" + iamRoleArn; | |||
| } | |||
|
|
|||
| private static AssumeRoleRequest createAssumeRoleRequest(@QueryParameter("iamRoleArn") String iamRoleArn) { | |||
| private static AssumeRoleRequest createAssumeRoleRequest(String iamRoleArn) { | |||
|
Yes, I can take care of it. Thanks!
El El vie, 9 nov 2018 a las 23:16, Oleg Nenashev <[email protected]>
escribió:
… ***@***.**** approved this pull request.
LGTM, not sure who is the current maintainer.
@andresrc <https://github.com/andresrc> are you still interested in it?
------------------------------
In
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
<#46 (comment)>
:
> @@ -156,7 +161,7 @@ public String getDisplayName() {
return accessKey + ":" + iamRoleArn;
}
- private static AssumeRoleRequest ***@***.***("iamRoleArn") String iamRoleArn) {
+ private static AssumeRoleRequest createAssumeRoleRequest(String iamRoleArn) {
Copy-pasta, I believe
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#46 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeiyC7ikugRA9-FHiIwQrJmrC-wb1q9ks5utf6tgaJpZM4Xdbc3>
.
|
carlossg
approved these changes
Nov 9, 2018
jglick
added a commit
to jglick/pipeline-cloudwatch-logs-plugin
that referenced
this pull request
Nov 16, 2018
…released, do not depend on it for now.
andresrc
approved these changes
Nov 18, 2018
|
Released as 1.24 |
jglick
added a commit
to jglick/pipeline-cloudwatch-logs-plugin
that referenced
this pull request
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstanceProfileCredentialsProvideronly works under limited conditions. It is simpler and better to use the default provider chain from the AWS SDK.May fix #29. Amends #20. Subsumes #41.
Who is the maintainer these days? CC @carlossg