Define default region for STS actions to fix regression introduced in 1.24 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresrc
requested changes
Feb 24, 2019
| clientRegion = sdkRegionLookup.getRegion(); | ||
| } | ||
| catch(com.amazonaws.SdkClientException e) { | ||
| if (e.getMessage() == "Unable to load region information from any provider in the chain") { |
There was a problem hiding this comment.
Matching in the exception message is pretty weak. In this case I would log the exception and move forward and outside the try block if clientRegion is still null, set it to Regions.DEFAULT_REGION.getName()
nathandines
force-pushed
the
bugfix/default-region
branch
from
2199ce6
to
3b26433
Compare
nathandines
force-pushed
the
bugfix/default-region
branch
from
3b26433
to
80e5ccf
Compare
|
@andresrc I've made some changes. Awaiting feedback |
andresrc
approved these changes
Feb 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47