Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-57426] Make pipeline-model-extensions dependency optional #54

Merged
merged 1 commit into from
May 14, 2019

Conversation

escoem
Copy link
Contributor

@escoem escoem commented May 13, 2019

Can @abayer @amuniz please review it?

pipeline-model-extensions doesn't seem to be a required dependency. It is since #50 had been merged introducing undesired transitive dependencies.

Copy link
Member

@amuniz amuniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

@escoem escoem merged commit ae856df into jenkinsci:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants