Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a @Symbol to AmazonWebServicesCredentialsBinding #65

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 10, 2019

According to existing bindings this seems a reasonable choice. E.g.

withCredentials([aws(credentialsId: '')]) {
  sh 'aws …'
}

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to keep in mind is that JCasC plugin is still bad at conflicting symbol resolution (AFAIK). This particular piece of code is right in general, but I am not sure whether we can expect regressions in JCasC.

CC @Casz @timja @MRamonLeon

@timja
Copy link
Member

timja commented Jun 13, 2019

Should be fine, we hit an issue with a symbol collision in job-dsl but that was because the namespace symbol wasn't working correctly. Jesse fixed it in structs I believe.

@jetersen
Copy link
Member

I am not too concerned, if need be we would need some filtering for symbols on JCasC's end. JCasC, for instance, could ignore symbols related to CredentialsBinding if such information is available in structs-plugin or perhaps could be added.

@escoem escoem merged commit 412c180 into jenkinsci:master Nov 5, 2019
@multani
Copy link

multani commented Dec 13, 2019

@escoem Do you think we could have a new release with that change?
That would clean up our Jenkins quite a bit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants