[JENKINS-58842] - Trim Jenkins name for Role Session Names to avoid issues with trailing spaces in localizations #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssues with trailing spaces in localizations
rsandell
approved these changes
Aug 16, 2019
|
jenkinsci/jenkins#4145 for the fix on the core side |
jglick
reviewed
Aug 16, 2019
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Outdated
Show resolved
Hide resolved
MRamonLeon
approved these changes
Aug 16, 2019
escoem
approved these changes
Aug 19, 2019
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Outdated
Show resolved
Hide resolved
…CredentialsImpl.java Co-Authored-By: Jesse Glick <[email protected]>
|
@escoem OK, integrated the change |
jglick
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What could possibly go wrong when one uses a localized field for an AWS request session name? I have no idea why this field is used, maybe somebody overrides the "Jenkins" name in such way. I leave a full fix to the plugin maintainers who know the use-case, just fixing an obvious issue reported in https://issues.jenkins-ci.org/browse/JENKINS-58842
Fixes #67
CC @diegombeltran