Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charmhelpers.fetch.python.pip_install should use the juju proxy variables JUJU_CHARM_*_PROXY #614

Open
jguedez opened this issue Jun 30, 2021 · 1 comment

Comments

@jguedez
Copy link

jguedez commented Jun 30, 2021

pip_install and other related utilities in charmhelpers.fetch.python [0] should handle the special juju proxy variables JUJU_CHARM_*_PROXY [1]

It seems like this has already been done in other relevant parts of the library [2]. We can use the same approach and leverage the added helpers like env_proxy_settings for the python package utilities. pip_install does have a proxy option, but it would be ideal to handle it in the library according to best practices instead of having to repeat this on each charm.

[0] https://github.com/juju/charm-helpers/blob/master/charmhelpers/fetch/python/packages.py#L85
[1] https://discourse.charmhub.io/t/command-model-config/1768
[2] #248

@jguedez jguedez changed the title charmhelpers.fetch.python.pip_install should use the handle the juju proxy variables JUJU_CHARM_*_PROXY charmhelpers.fetch.python.pip_install should use the juju proxy variables JUJU_CHARM_*_PROXY Jun 30, 2021
@afreiberger
Copy link
Contributor

Also this should apply to charmhelpers.fetch.giturl as well. git clone doesn't utilize the http/https proxy variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants