Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AndroidX #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AndroidX #260

wants to merge 1 commit into from

Conversation

mrtungdev
Copy link

No description provided.

@rdlabo
Copy link

rdlabo commented Aug 2, 2020

@ImTung Thanks for awesome pull request. I get success to build android:

npm i cordova-plugin-printer@[email protected]:ImTung/cordova-plugin-printer.git

I'm looking forward to be merged this pull request.

@johannesschobel
Copy link

This PR needs to be merged ASAP!

@johannesschobel
Copy link

if you would like to use it directly within the package.json file, you can add this "temporary branch" as follows

{
  // ...
  "dependencies": {
    // ...
    "cordova-plugin-printer": "ImTung/cordova-plugin-printer",
  },
  "devDependencies": {
    // ...
  }
}

@AltenTMAOrion
Copy link

Up for merge this Pull Request

@FawzyMokhtar
Copy link

This PR should be merged ASAP..!

@jonashger
Copy link

This PR needs to be merged ASAP!

@Romone183
Copy link

You still have to change the plugin.xml file

 <preference name="ANDROIDX_PRINT_VERSION" default="1.0.0"/>
        <framework src="androidx.print:print:$ANDROIDX_PRINT_VERSION" />

@andreszs
Copy link

Ground control to Major Katzer, do you hear me Major @katzer? This merge will fix cordova-android@10+ build errors. @

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants