Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema index signature type unsoundness #1007

Merged

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 26, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: #1006

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runtime/src/value/api.rs
  • kclvm/runtime/src/value/val_schema.rs
  • kclvm/sema/src/resolver/schema.rs
  • kclvm/sema/src/resolver/ty.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Unit test cases

  • kclvm/sema/src/resolver/tests.rs

Grammar test cases

  • test/grammar/schema/assign_stmt/fail_0/main.k
  • test/grammar/schema/index_signature/**

@Peefy Peefy added bug Something isn't working runtime Issues or PRs related to kcl runtime including value and value opertions resolver labels Jan 26, 2024
@Peefy Peefy added this to the v0.8.0 Release milestone Jan 26, 2024
@Peefy Peefy requested review from He1pa and zong-zhe January 26, 2024 05:38
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7664429514

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.787%

Totals Coverage Status
Change from base Build 7650865619: 0.0%
Covered Lines: 2293
Relevant Lines: 2612

💛 - Coveralls

Signed-off-by: peefy <[email protected]>
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7664483429

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.787%

Totals Coverage Status
Change from base Build 7650865619: 0.0%
Covered Lines: 2293
Relevant Lines: 2612

💛 - Coveralls

@Peefy Peefy merged commit 6cf7389 into kcl-lang:main Jan 26, 2024
10 of 11 checks passed
@Peefy Peefy deleted the fix-schema-index-signature-type-unsoundness branch January 26, 2024 06:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working resolver runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Type Unsoundness for the schema index signature.
3 participants