Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: LSP will execute 'kpm metadata' to get the localpath of the kcl dependecies. #554

Merged
merged 7 commits into from
May 18, 2023
Merged

Feat: LSP will execute 'kpm metadata' to get the localpath of the kcl dependecies. #554

merged 7 commits into from
May 18, 2023

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #543

2. What is the scope of this PR (e.g. component or file name):

LSP

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

LSP will execute 'kpm metadata' to get the localpath of the kcl dependecies.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe added the enhancement New feature or request label May 17, 2023
@zong-zhe zong-zhe added this to the v0.5.0 Release milestone May 17, 2023
@zong-zhe zong-zhe self-assigned this May 17, 2023
@coveralls
Copy link
Collaborator

coveralls commented May 17, 2023

Pull Request Test Coverage Report for Build 5012305815

  • 310 of 329 (94.22%) changed or added relevant lines in 9 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-20.0%) to 68.011%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/query/src/override.rs 0 1 0.0%
kclvm/parser/src/lib.rs 15 17 88.24%
kclvm/tools/src/LSP/src/util.rs 49 51 96.08%
kclvm/driver/src/lib.rs 5 11 45.45%
kclvm/driver/src/kpm_metadata.rs 78 86 90.7%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 50.0%
Totals Coverage Status
Change from base Build 5002236047: -20.0%
Covered Lines: 30794
Relevant Lines: 45278

💛 - Coveralls

kclvm/ast/src/ast.rs Show resolved Hide resolved
kclvm/tools/src/LSP/src/goto_def.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/goto_def.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/goto_def.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 8cf533f into kcl-lang:main May 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: LSP needs to request kpm to get the path of external dependencies.
3 participants