Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unsound schema runtime check. #583

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jun 25, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #542

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/runtime/src/value/api.rs
  • kclvm/runtime/src/value/val_type.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

fix: unsound schema runtime check including optional attributes and relaxed attributes

TODO: refactor runtime value union options.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/schema/optional_attr/fail**/**
  • test/grammar/schema/relaxed/fail**/**

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy requested review from NeverRaR and zong-zhe June 25, 2023 04:00
@Peefy Peefy self-assigned this Jun 25, 2023
@Peefy Peefy added the runtime Issues or PRs related to kcl runtime including value and value opertions label Jun 25, 2023
@Peefy Peefy added this to the v0.5.0 Release milestone Jun 25, 2023
@Peefy Peefy force-pushed the fix-unsound-schema-runtime-check branch from 7a1367d to 79e0f52 Compare June 25, 2023 05:21
@Peefy Peefy force-pushed the fix-unsound-schema-runtime-check branch from 79e0f52 to 8edc5c8 Compare June 25, 2023 06:25
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5368274088

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 5368121804: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5368258770

  • 4 of 17 (23.53%) changed or added relevant lines in 5 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-19.9%) to 68.09%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/stdlib/builtin.rs 0 2 0.0%
kclvm/runtime/src/value/val_plan.rs 0 2 0.0%
kclvm/runtime/src/value/api.rs 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 50.0%
Totals Coverage Status
Change from base Build 5368121804: -19.9%
Covered Lines: 30928
Relevant Lines: 45422

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit b73871c into kcl-lang:main Jun 25, 2023
7 of 8 checks passed
@Peefy Peefy deleted the fix-unsound-schema-runtime-check branch June 25, 2023 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Unsound internal schema runtime check.
3 participants