Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance required attr check #587

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jun 27, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #583

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/compiler/src/codegen/llvm/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the runtime Issues or PRs related to kcl runtime including value and value opertions label Jun 27, 2023
@Peefy Peefy added this to the v0.5.0 Release milestone Jun 27, 2023
@Peefy Peefy requested a review from zong-zhe June 27, 2023 09:13
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Jun 27, 2023

Pull Request Test Coverage Report for Build 5387986563

  • 5 of 28 (17.86%) changed or added relevant lines in 4 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-19.9%) to 68.045%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/value/val_schema.rs 4 5 80.0%
kclvm/runtime/src/value/val_type.rs 0 4 0.0%
kclvm/runtime/src/value/api.rs 0 18 0.0%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 50.0%
Totals Coverage Status
Change from base Build 5369007997: -19.9%
Covered Lines: 30880
Relevant Lines: 45382

💛 - Coveralls

@Peefy Peefy merged commit a5ba758 into kcl-lang:main Jun 27, 2023
9 of 11 checks passed
@Peefy Peefy deleted the enhance-required-attr-check branch June 27, 2023 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants