Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix empty identifier expr position #593

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 3, 2023

fix empty identifier expr postion and completion for literal str in lsp

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

parser, lsp

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa added bug Something isn't working parser Issues or PRs related to kcl parser lsp labels Jul 3, 2023
@He1pa He1pa self-assigned this Jul 3, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jul 3, 2023

Pull Request Test Coverage Report for Build 5442924724

  • 64 of 64 (100.0%) changed or added relevant lines in 3 files are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-19.9%) to 68.061%

Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 50.0%
Totals Coverage Status
Change from base Build 5442553920: -19.9%
Covered Lines: 30929
Relevant Lines: 45443

💛 - Coveralls

@He1pa He1pa force-pushed the bugfix_empty_ident_expr_pos branch from 032c770 to b9a2b2c Compare July 3, 2023 09:27
@He1pa He1pa force-pushed the bugfix_empty_ident_expr_pos branch from b9a2b2c to 0f4d02f Compare July 3, 2023 09:34
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 0a32341 into kcl-lang:main Jul 3, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working lsp parser Issues or PRs related to kcl parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement][Track] KCL VSCode IDE extension and lsp enhancement
3 participants