-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: refactor find def in LSP #606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5587176592
💛 - Coveralls |
Peefy
reviewed
Jul 12, 2023
61 tasks
Peefy
reviewed
Jul 13, 2023
4257e43
to
31af04c
Compare
Privide functions find_def and resolver_var in LSP to find identifier definition scopeobj. Support finding definitions with different names in one identifier
31af04c
to
7cb83c5
Compare
Peefy
reviewed
Jul 18, 2023
6f033cb
to
8480536
Compare
8480536
to
170eacc
Compare
Peefy
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Privide functions find_def and resolver_var in LSP to find identifier definition scopeobj. Support finding definitions with different names in one identifier
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
LSP
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
refactor find_def in LSP.
before: Search all scope obj which name is
c
after: Recursively lookup definitions on the inner most scope. Find definition of a, jump to a's scope and search b definition, and c.
So now we can lookup definitions of different names on one ident. It can be used for goto def, hover documents, etc.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: