Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add position for each name in identifier #608

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 14, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

AST
Parser

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Add position for each name in identifier AST

pub struct Identifier {
-     pub names: Vec<String>,
+    pub names: Vec<Node<String>>,
}
  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5551524322

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 5531819778: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jul 14, 2023

Pull Request Test Coverage Report for Build 5552807687

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 5531819778: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

@Peefy Peefy added refactor parser Issues or PRs related to kcl parser labels Jul 14, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Jul 14, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM.

@Peefy Peefy merged commit 0630513 into kcl-lang:main Jul 17, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
parser Issues or PRs related to kcl parser refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants