Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lsp completion of pkg, var and schema attr #614

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 20, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

LSP
Scope

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

feat: lsp completion of pkg, var and schema attr

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa force-pushed the attr_completion branch 2 times, most recently from 1ba764c to 1dc8c9e Compare July 21, 2023 06:39
@He1pa He1pa marked this pull request as ready for review July 21, 2023 06:42
@He1pa He1pa changed the title [WIP] feat: lsp completion of pkg, var and schema attr feat: lsp completion of pkg, var and schema attr Jul 21, 2023
@He1pa He1pa added the lsp label Jul 21, 2023
kclvm/tools/src/LSP/src/completion.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/completion.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/scope.rs Show resolved Hide resolved
kclvm/tools/src/LSP/src/completion.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/completion.rs Outdated Show resolved Hide resolved
kclvm/tools/src/LSP/src/completion.rs Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Jul 25, 2023

Pull Request Test Coverage Report for Build 5653653220

  • 243 of 260 (93.46%) changed or added relevant lines in 9 files are covered.
  • 26 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-19.4%) to 68.547%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/document_symbol.rs 0 1 0.0%
kclvm/tools/src/LSP/src/goto_def.rs 3 4 75.0%
kclvm/tools/src/LSP/src/util.rs 9 11 81.82%
kclvm/sema/src/resolver/scope.rs 21 24 87.5%
kclvm/tools/src/LSP/src/completion.rs 100 110 90.91%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 26 58.06%
Totals Coverage Status
Change from base Build 5644626118: -19.4%
Covered Lines: 31555
Relevant Lines: 46034

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit fd85ed0 into kcl-lang:main Jul 25, 2023
19 of 20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants