Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enhance kcl and its tool cli error message and add more tests. #618

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 24, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

refactor: enhance kcl and its tool cli error message and add more tests.

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/cmd/src/lib.rs
  • kclvm/cmd/src/lint.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/cmd/src/tests.rs

@Peefy Peefy added error-handling Issues or PRs related to kcl error handling refactor labels Jul 24, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Jul 24, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5641529467

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 5607034697: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 87f4da1 into kcl-lang:main Jul 24, 2023
10 checks passed
@Peefy Peefy deleted the enhance-tool-cli-error-msg branch July 24, 2023 07:01
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-handling Issues or PRs related to kcl error handling refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants