Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix performance regression on resolver::parse_doc_string #619

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jul 24, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #576

2. What is the scope of this PR (e.g. component or file name):

sema/resolver/doc.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Use pcre2 to replace std::Reegex

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
    Manual test sema/resolver/tests::test_resolve_schema_doc and got 10-20 times enhance on method strip_quotes

Before
image

After:
image

@He1pa He1pa force-pushed the fix_performance_regression_on_resolver branch from 5da4d2b to 4b2e1b0 Compare July 24, 2023 11:19
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5644190099

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 5641809539: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM

@Peefy Peefy merged commit 78e7b20 into kcl-lang:main Jul 24, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Resolver doc parser performance problem
3 participants