Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump serde_yaml to latest to solve security issues and error test cases #623

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 25, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

chore: bump serde_yaml to latest to solve security issues and error test cases

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/**/Cargo.toml
  • Some grammar test cases
    • test/grammar/builtins/default/bin/stdout.golden
    • test/grammar/builtins/default/oct/stdout.golden
    • test/grammar/schema/union/binary_union/binary_union_5/stdout.golden

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • All unit and grammar integration test cases

@Peefy Peefy added release dependencies Pull requests that update a dependency file security labels Jul 25, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Jul 25, 2023
@Peefy Peefy requested review from He1pa and zong-zhe July 25, 2023 13:04
@Peefy Peefy self-assigned this Jul 25, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jul 25, 2023

Pull Request Test Coverage Report for Build 5663917852

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 5653910345: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 77b6a25 into kcl-lang:main Jul 26, 2023
10 checks passed
@Peefy Peefy deleted the bump-serde-yaml-deps branch July 26, 2023 03:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants