Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance get schema type API with more information. #633

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 1, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Close #625
Close #629

feat: enhance get schema type API with more information.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • kclvm/api/src/testdata/get-schema-type-mapping.json
  • kclvm/api/src/testdata/get-schema-type-mapping.response.json

@Peefy Peefy added the api Issues or PRs related to kcl rust native APIs and multi-lang APIs label Aug 1, 2023
@Peefy Peefy added this to the v0.6.0 Release milestone Aug 1, 2023
@Peefy Peefy changed the title feat: enhance get schema ty API with more information. feat: enhance get schema type API with more information. Aug 1, 2023
@Peefy Peefy changed the title feat: enhance get schema type API with more information. [WIP] feat: enhance get schema type API with more information. Aug 1, 2023
@amyXia1994
Copy link
Contributor

Just a remind: please also update the multi-language APIs in kcl-go, kcl-... repos

@Peefy Peefy changed the title [WIP] feat: enhance get schema type API with more information. feat: enhance get schema type API with more information. Aug 1, 2023
@Peefy Peefy force-pushed the enhance-get-schema-ty-api branch from abfd7e2 to adb13fe Compare August 1, 2023 13:29
@coveralls
Copy link
Collaborator

coveralls commented Aug 1, 2023

Pull Request Test Coverage Report for Build 5727670814

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • 26 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-19.2%) to 68.818%

Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 26 58.06%
Totals Coverage Status
Change from base Build 5714578495: -19.2%
Covered Lines: 31880
Relevant Lines: 46325

💛 - Coveralls

@amyXia1994 amyXia1994 merged commit 19680af into kcl-lang:main Aug 2, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
@Peefy Peefy deleted the enhance-get-schema-ty-api branch August 2, 2023 05:09
@Peefy Peefy self-assigned this Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api Issues or PRs related to kcl rust native APIs and multi-lang APIs
Projects
None yet
3 participants