Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add and check the k code list to the entry. #642

Merged
merged 2 commits into from
Aug 7, 2023
Merged

fix: add and check the k code list to the entry. #642

merged 2 commits into from
Aug 7, 2023

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Aug 7, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

kclvm_parser

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the bug Something isn't working label Aug 7, 2023
@zong-zhe zong-zhe added this to the v0.6.0 Release milestone Aug 7, 2023
@zong-zhe zong-zhe requested review from Peefy and He1pa August 7, 2023 12:16
@zong-zhe zong-zhe self-assigned this Aug 7, 2023
@coveralls
Copy link
Collaborator

coveralls commented Aug 7, 2023

Pull Request Test Coverage Report for Build 5785017825

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 87.988%

Files with Coverage Reduction New Missed Lines %
compiler_base/parallel/src/executor/timeout.rs 1 92.98%
Totals Coverage Status
Change from base Build 5782324605: -0.04%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit a8cabd2 into kcl-lang:main Aug 7, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants