Merge pull request #321 from officialasishkumar/kpm-add-rename

fix: rename in kpm add
kcl-lang · May 20, 2024 · d2af32c · d2af32c
2 parents 2e4fda3 + 3386e0f
commit d2af32c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/pkg/client/client.go b/pkg/client/client.go
@@ -655,8 +655,11 @@ func (c *KpmClient) AddDepWithOpts(kclPkg *pkg.KclPkg, opt *opt.AddOptions) (*pk
 
 	// 3. update the kcl.mod and kcl.mod.lock.
 	if opt.NewPkgName != "" {
-		d.ChangePkgName(opt.NewPkgName)
+		tempDeps := kclPkg.ModFile.Dependencies.Deps[d.Name]
+		tempDeps.Name = opt.NewPkgName
+		kclPkg.ModFile.Dependencies.Deps[d.Name] = tempDeps
 	}
+
 	err = kclPkg.UpdateModAndLockFile()
 	if err != nil {
 		return nil, err

diff --git a/pkg/package/modfile.go b/pkg/package/modfile.go
@@ -266,10 +266,6 @@ func (dep *Dependency) GetDownloadPath() string {
 	return ""
 }
 
-func (dep *Dependency) ChangePkgName(NewPkgName string) {
-	dep.Name = NewPkgName
-}
-
 func GenSource(sourceType string, uri string, tagName string) (Source, error) {
 	source := Source{}
 	if sourceType == GIT {