Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design of selection strategy #271

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

AkashKumar7902
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: #269

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@coveralls
Copy link

coveralls commented Feb 24, 2024

Pull Request Test Coverage Report for Build 8337308773

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.407%

Totals Coverage Status
Change from base Build 8322161610: 0.0%
Covered Lines: 1730
Relevant Lines: 4178

💛 - Coveralls

@AkashKumar7902 AkashKumar7902 changed the title [WIP] study on selection strategy design of selection strategy Mar 13, 2024
@AkashKumar7902
Copy link
Contributor Author

@zong-zhe Please take a look !

@Peefy
Copy link
Contributor

Peefy commented Mar 19, 2024

I think this design LGTM. Can you sign the DCO? We may merge at an appropriate time.

Besides, @zong-zhe, do you have any more suggestions and additions?

@zong-zhe
Copy link
Contributor

@AkashKumar7902 😄

LGTM, maybe you need to squash commits into one and sign the DCO with the one commit.

Signed-off-by: Akash Kumar <[email protected]>
@AkashKumar7902
Copy link
Contributor Author

@zong-zhe done!

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 09384d9 into kcl-lang:main Mar 19, 2024
5 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants