Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing version when add dependencies from local path #286

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Mar 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re kcl-lang/kcl#1162

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the bug Something isn't working label Mar 27, 2024
@zong-zhe zong-zhe requested a review from Peefy March 27, 2024 02:00
@zong-zhe zong-zhe self-assigned this Mar 27, 2024
@coveralls
Copy link

coveralls commented Mar 27, 2024

Pull Request Test Coverage Report for Build 8445903355

Details

  • 24 of 44 (54.55%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 41.496%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/package/modfile.go 8 16 50.0%
pkg/client/client.go 16 28 57.14%
Files with Coverage Reduction New Missed Lines %
pkg/client/client.go 1 55.52%
Totals Coverage Status
Change from base Build 8419167805: -0.08%
Covered Lines: 1825
Relevant Lines: 4398

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 90314fd into kcl-lang:main Mar 27, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants