-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement mvs specific functions (buildList, Upgrade, Downgrade) #292
Conversation
…s graph key value type Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
…version field Signed-off-by: Akash Kumar <[email protected]>
@zong-zhe Can you help review and provide some more professional comments and guidance? Thank you! |
pkg/client/test_data/add_with_git_commit/test_pkg/kcl.mod.lock.expect
Outdated
Show resolved
Hide resolved
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
The PR conflict, please rebase the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
@Peefy I have resolved the conflict, also current lint failure is due to the code imported from go codebase, things might break if we change 3rdparty code to fix lint issue. |
I will send another PR containing all the cmd commands. |
OK, you can fix the unit tests firstly. |
7fbf385
to
35dd736
Compare
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
6c68049
to
f5b3601
Compare
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
Pull Request Test Coverage Report for Build 9089374989Details
💛 - Coveralls |
@@ -235,3 +235,16 @@ func TestGetFilePath(t *testing.T) { | |||
assert.Equal(t, mfile.GetModFilePath(), filepath.Join(testPath, MOD_FILE)) | |||
assert.Equal(t, mfile.GetModLockFilePath(), filepath.Join(testPath, MOD_LOCK_FILE)) | |||
} | |||
|
|||
func TestGenSource(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestAddWithGitCommit failed on windows in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it!
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
Implementation of previous, upgrade, required, max from go mvs
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix #246
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: