feat: implement mvs specific functions (buildList, Upgrade, Downgrade) #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s graph key value type Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
…version field Signed-off-by: Akash Kumar <[email protected]>
|
@zong-zhe Can you help review and provide some more professional comments and guidance? Thank you! |
Peefy
reviewed
Apr 10, 2024
pkg/client/test_data/add_with_git_commit/test_pkg/kcl.mod.lock.expect
Outdated
Show resolved
Hide resolved
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
AkashKumar7902
changed the title
|
The PR conflict, please rebase the main branch. |
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
|
@Peefy I have resolved the conflict, also current lint failure is due to the code imported from go codebase, things might break if we change 3rdparty code to fix lint issue. |
|
I will send another PR containing all the cmd commands. |
OK, you can fix the unit tests firstly. |
AkashKumar7902
force-pushed
the
lfx-2024
branch
2 times, most recently
from
7fbf385
to
35dd736
Compare
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
AkashKumar7902
force-pushed
the
lfx-2024
branch
2 times, most recently
from
6c68049
to
f5b3601
Compare
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
Pull Request Test Coverage Report for Build 9089374989Details
💛 - Coveralls |
Peefy
reviewed
May 15, 2024
| @@ -235,3 +235,16 @@ func TestGetFilePath(t *testing.T) { | |||
| assert.Equal(t, mfile.GetModFilePath(), filepath.Join(testPath, MOD_FILE)) | |||
| assert.Equal(t, mfile.GetModLockFilePath(), filepath.Join(testPath, MOD_LOCK_FILE)) | |||
| } | |||
|
|
|||
| func TestGenSource(t *testing.T) { | |||
There was a problem hiding this comment.
TestAddWithGitCommit failed on windows in CI.
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
Signed-off-by: Akash Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of previous, upgrade, required, max from go mvs
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
fix #246
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: