Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mvs to update command #319

Merged
merged 3 commits into from
May 20, 2024
Merged

add mvs to update command #319

merged 3 commits into from
May 20, 2024

Conversation

AkashKumar7902
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: Akash Kumar <[email protected]>
@AkashKumar7902
Copy link
Contributor Author

@Peefy please take a look

@Peefy Peefy requested review from Peefy and zong-zhe May 17, 2024 02:23
pkg/cmd/cmd_update.go Outdated Show resolved Hide resolved
pkg/cmd/cmd_update.go Show resolved Hide resolved
pkg/cmd/cmd_update.go Show resolved Hide resolved
pkg/cmd/cmd_update.go Outdated Show resolved Hide resolved
@Peefy
Copy link
Contributor

Peefy commented May 17, 2024

Windows CI failed. https://github.com/kcl-lang/kpm/actions/runs/9127391533/job/25097559490?pr=319
cc @zong-zhe Could you please review this PR and #292

@AkashKumar7902 AkashKumar7902 force-pushed the lfx-2024 branch 3 times, most recently from 89d51ca to 1b7041c Compare May 17, 2024 11:30
@AkashKumar7902 AkashKumar7902 force-pushed the lfx-2024 branch 8 times, most recently from 5342cd0 to 04cf317 Compare May 19, 2024 13:57
Signed-off-by: Akash Kumar <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 2e4fda3 into kcl-lang:main May 20, 2024
3 of 6 checks passed
@AkashKumar7902
Copy link
Contributor Author

Hey @Peefy
are there any more deliverables left for the LFX term?

@Peefy
Copy link
Contributor

Peefy commented May 20, 2024

Hey @Peefy are there any more deliverables left for the LFX term?

No, your work is excellent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
2 participants