Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename in kpm add #321

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

officialasishkumar
Copy link
Contributor

@officialasishkumar officialasishkumar commented May 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #288

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: Asish Kumar <[email protected]>
@officialasishkumar officialasishkumar marked this pull request as draft May 19, 2024 04:49
@officialasishkumar officialasishkumar marked this pull request as ready for review May 19, 2024 04:57
pkg/client/client.go Outdated Show resolved Hide resolved
Signed-off-by: Asish Kumar <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit d2af32c into kcl-lang:main May 20, 2024
2 of 6 checks passed
@Peefy
Copy link
Contributor

Peefy commented May 20, 2024

Hello @officialasishkumar I've tried the new kpm add --rename hh helloworld and it still seems to be working incorrectly. 💔

@officialasishkumar
Copy link
Contributor Author

officialasishkumar commented May 20, 2024

Hello @Peefy, I ran /home/charon/coding/open-source/kcl-lang/kpm/kpm add --rename hh helloworld and the kcl.mod file looks like

[dependencies]
hh = { oci = "oci://ghcr.io/kcl-lang/helloworld", tag = "0.1.2" }

@Peefy
Copy link
Contributor

Peefy commented May 20, 2024

@officialasishkumar Sorry, I told wrong error messages. The name in the kcl.mod.lock file should be the new name.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants