Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use orderedmap replace map for dependencies in kcl.mod #373

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Jul 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

closes #333

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe requested a review from Peefy July 4, 2024 07:08
@zong-zhe zong-zhe self-assigned this Jul 4, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9789998934

Details

  • 105 of 152 (69.08%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 44.381%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd_update.go 0 3 0.0%
pkg/package/toml.go 27 31 87.1%
pkg/package/package.go 4 9 44.44%
pkg/package/modfile.go 7 21 33.33%
pkg/client/client.go 59 80 73.75%
Totals Coverage Status
Change from base Build 9576048206: 0.2%
Covered Lines: 2638
Relevant Lines: 5944

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9790227553

Details

  • 113 of 160 (70.63%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 44.454%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd_update.go 0 3 0.0%
pkg/package/toml.go 35 39 89.74%
pkg/package/package.go 4 9 44.44%
pkg/package/modfile.go 7 21 33.33%
pkg/client/client.go 59 80 73.75%
Totals Coverage Status
Change from base Build 9576048206: 0.3%
Covered Lines: 2645
Relevant Lines: 5950

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9790242714

Details

  • 113 of 160 (70.63%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 44.454%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd_update.go 0 3 0.0%
pkg/package/toml.go 35 39 89.74%
pkg/package/package.go 4 9 44.44%
pkg/package/modfile.go 7 21 33.33%
pkg/client/client.go 59 80 73.75%
Totals Coverage Status
Change from base Build 9576048206: 0.3%
Covered Lines: 2645
Relevant Lines: 5950

💛 - Coveralls

@zong-zhe zong-zhe merged commit 9a5e971 into kcl-lang:main Jul 4, 2024
5 checks passed
zong-zhe added a commit to zong-zhe/kpm that referenced this pull request Jul 4, 2024
…g#373)

* feat: use orderedmap replace map for dependencies in kcl.mod

Signed-off-by: Asish Kumar <[email protected]>

* fix: finish the replacement

Signed-off-by: zongz <[email protected]>

* fix: add newline between [profile] and [dependencies]

Signed-off-by: zongz <[email protected]>

---------

Signed-off-by: Asish Kumar <[email protected]>
Signed-off-by: zongz <[email protected]>
Co-authored-by: Asish Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
4 participants