Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unified api for CLI pull command #376

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Jul 4, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #289

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Jul 4, 2024
@zong-zhe zong-zhe requested a review from Peefy July 4, 2024 11:03
@zong-zhe zong-zhe self-assigned this Jul 4, 2024
@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9793195889

Details

  • 106 of 724 (14.64%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-4.1%) to 40.261%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd_push.go 0 1 0.0%
pkg/downloader/downloader.go 16 23 69.57%
pkg/package/modfile.go 9 18 50.0%
pkg/package/package.go 0 11 0.0%
pkg/client/client.go 34 52 65.38%
pkg/client/pull.go 46 64 71.88%
pkg/utils/utils.go 0 28 0.0%
pkg/downloader/toml.go 0 158 0.0%
pkg/downloader/source.go 0 368 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/oci/oci.go 1 23.46%
Totals Coverage Status
Change from base Build 9791206524: -4.1%
Covered Lines: 2592
Relevant Lines: 6438

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 9794141648

Details

  • 107 of 735 (14.56%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-4.2%) to 40.208%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd_push.go 0 1 0.0%
pkg/package/modfile.go 9 18 50.0%
pkg/package/package.go 0 11 0.0%
pkg/downloader/downloader.go 17 34 50.0%
pkg/client/client.go 34 52 65.38%
pkg/client/pull.go 46 64 71.88%
pkg/utils/utils.go 0 28 0.0%
pkg/downloader/toml.go 0 158 0.0%
pkg/downloader/source.go 0 368 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/oci/oci.go 1 23.46%
Totals Coverage Status
Change from base Build 9791206524: -4.2%
Covered Lines: 2593
Relevant Lines: 6449

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit efc7b9c into kcl-lang:main Jul 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants