Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cache for credential to reduce the probability that kpm would be considered a threat #388

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Jul 18, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re https://github.com/orgs/kcl-lang/discussions/1422

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Jul 18, 2024
@zong-zhe zong-zhe requested a review from Peefy July 18, 2024 07:37
@zong-zhe zong-zhe self-assigned this Jul 18, 2024
@zong-zhe zong-zhe changed the title feat: add cache for credential to reduce the probability that kpm wou… feat: add cache for credential to reduce the probability that kpm would be considered a threat Jul 18, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 635551d into kcl-lang:main Jul 18, 2024
5 of 7 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9987465755

Details

  • 103 of 211 (48.82%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 39.803%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/visitor.go 3 5 60.0%
pkg/downloader/downloader.go 14 22 63.64%
pkg/oci/oci.go 34 46 73.91%
pkg/downloader/credential.go 0 27 0.0%
pkg/client/client.go 52 111 46.85%
Totals Coverage Status
Change from base Build 9970449927: 0.2%
Covered Lines: 3029
Relevant Lines: 7610

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Enhancement: kpm add command displaying optimization
3 participants