Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the two routes with the same path conflicts #160

Merged
merged 1 commit into from
Apr 2, 2023
Merged

fix the two routes with the same path conflicts #160

merged 1 commit into from
Apr 2, 2023

Conversation

ivanoff
Copy link
Contributor

@ivanoff ivanoff commented Aug 16, 2022 •
edited

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@ivanoff
Copy link
Contributor Author

ivanoff commented Aug 16, 2022

fix of the following issue: #139

@ivanoff ivanoff mentioned this pull request Aug 16, 2022
Closed
@etroynov
Copy link
Contributor

@titanism @3imed-jaberi can you check it?

@3imed-jaberi 3imed-jaberi changed the title feat: 139 two routes with the same path fix two routes with the same path conflicts Apr 2, 2023
@3imed-jaberi 3imed-jaberi changed the title fix two routes with the same path conflicts fix the two routes with the same path conflicts Apr 2, 2023
3imed-jaberi
3imed-jaberi approved these changes Apr 2, 2023
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks, @ivanoff for your contribution.

@3imed-jaberi 3imed-jaberi merged commit bc13548 into koajs:master Apr 2, 2023
@3imed-jaberi 3imed-jaberi mentioned this pull request Apr 2, 2023
Closed
@WontonSam WontonSam mentioned this pull request Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3imed-jaberi 3imed-jaberi 3imed-jaberi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanoff @etroynov @3imed-jaberi