-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert conversion of 'debug' package for 'node:util::debuglog' #173
Conversation
@jeremy-daley-kr can you file a GitHub issue in Node.js that asks why |
Publishing v12.0.1 to npm now, almost done. |
I'll most likely backport to v11 as patch too. |
I'll see what I can do. Thanks for moving quickly with the merge. I'll keep my eye out for 12.0.1 👀 |
v12.0.1 released to npm and GitHub: |
Deprecation notice published for all versions of |
Manually backported and released as |
All done! 🎉 thanks again @jeremy-daley-kr - if you want some free credit for Forward Email just ping us at [email protected] once you sign up. 🖖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello i'm a beginner here, i have this error when i try to create my strapi project i have seen all these but i don't know how to process. I really need your help.
here is one of the errors:
@strapi/strapi > @koa/[email protected]: IMPORTANT 10x+ PERFORMANCE UPGRADE: Please upgrade to v12.0.1+ as we have fixed an issue with debuglog causing 10x slower router benchmark performance, see #173.
@MoFaro please read the deprecation and the issue. this is a warning to upgrade, not an error. it is a performance-related issue. |
Sorry to bump that one. But is it intended that version 11.0.2 has the "latest" tag instead of 12.0.1? |
@4nduril-ms amazing catch, I didn't specify |
@4nduril-ms I actually didn't need to do another package version bump, there's ❯ npm dist-tag add @koa/[email protected] latest
Authenticate your account at:
https://www.npmjs.com/auth/cli/xxx
Press ENTER to open in the browser...
+latest: @koa/[email protected]
❯ npm dist-tag add [email protected] latest
Authenticate your account at:
https://www.npmjs.com/auth/cli/xxx
Press ENTER to open in the browser...
+latest: [email protected] thanks again 🙏 |
@titanism Great! Thank you for fixing it that fast. |
@4nduril-ms of course, also if you need anything email related, check out our project https://forwardemail.net 🔥 |
See koajs/router#173 Signed-off-by: Vladimir Grichina <[email protected]>
Description
A major performance regression was detected amounting to about 10x speed decrease. This occurred by the changing of how router is debugged.
Please see the following discussion:
koajs/koa#1781
Checklist