Skip to content

Commit

Permalink
feat(api): add revision to non-anchor locations that may ref a file (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
schroederc committed Oct 1, 2020
1 parent 2918c49 commit 51c92b9
Show file tree
Hide file tree
Showing 2 changed files with 658 additions and 541 deletions.
17 changes: 16 additions & 1 deletion kythe/proto/xref.proto
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,13 @@ message DecorationsRequest {
bool semantic_scopes = 12;
}

// File represents a whole file
message File {
kythe.proto.common.CorpusPath corpus_path = 1;

string revision = 2;
}

message DecorationsReply {
// The normalized location for which decorations are returned.
Location location = 1;
Expand Down Expand Up @@ -202,6 +209,10 @@ message DecorationsReply {
// DecorationsRequest.
string semantic_scope = 7;

// The revision of the file being targeted by this reference, may be empty
// if targeting a non-file.
string target_revision = 8;

reserved 1, 10, 11;
}

Expand Down Expand Up @@ -243,7 +254,11 @@ message DecorationsReply {
repeated common.Diagnostic diagnostic = 5;

// List of tickets for files that generate the requested file.
repeated string generated_by = 6;
// Deprecated: use generated_by_file, if data available
repeated string generated_by = 6 [deprecated = true];

// List of files that generate the requested file.
repeated File generated_by_file = 19;

// This field will contain one entry, keyed by ticket, for each distinct node
// referenced by a reference edge that has at least 1 non-filtered fact.
Expand Down
Loading

0 comments on commit 51c92b9

Please sign in to comment.