fix(cxx_indexer): function definitions should influence declarations (#…

…4812)
kythe · Feb 2, 2021 · c741a38 · c741a38
1 parent ce3200a
commit c741a38
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/kythe/cxx/indexer/cxx/IndexerASTHooks.cc b/kythe/cxx/indexer/cxx/IndexerASTHooks.cc
@@ -3289,13 +3289,17 @@ bool IndexerASTVisitor::VisitFunctionDecl(clang::FunctionDecl* Decl) {
                 : GraphObserver::Specificity::Completes,
             OuterNode);
 
-        if (Decl->param_size() == NextDecl->param_size()) {
-          for (size_t param = 0; param < Decl->param_size(); ++param) {
-            auto lhs = NextDecl->getParamDecl(param);
-            auto rhs = Decl->getParamDecl(param);
-            if (DataflowEdges && lhs != nullptr && rhs != nullptr) {
-              Observer.recordInfluences(BuildNodeIdForDecl(lhs),
-                                        BuildNodeIdForDecl(rhs));
+        if (DataflowEdges) {
+          Observer.recordInfluences(OuterNode, TargetDecl);
+
+          if (Decl->param_size() == NextDecl->param_size()) {
+            for (size_t param = 0; param < Decl->param_size(); ++param) {
+              auto lhs = NextDecl->getParamDecl(param);
+              auto rhs = Decl->getParamDecl(param);
+              if (lhs != nullptr && rhs != nullptr) {
+                Observer.recordInfluences(BuildNodeIdForDecl(lhs),
+                                          BuildNodeIdForDecl(rhs));
+              }
             }
           }
         }

diff --git a/kythe/cxx/indexer/cxx/testdata/df/df_fncall_influence.cc b/kythe/cxx/indexer/cxx/testdata/df/df_fncall_influence.cc
@@ -11,6 +11,7 @@ int f(int a, int b);
 //- @f completes/uniquely FDecl
 //- VarA influences VarC
 //- VarB influences VarD
+//- FDefn influences FDecl
 int f(int c, int d) {
   //- VarC influences FDefn
   //- VarD influences FDefn

diff --git a/kythe/docs/schema/influences-relation.txt b/kythe/docs/schema/influences-relation.txt
@@ -155,5 +155,5 @@ int f(int x, int y) {
 
 //- FwdParamX influences DefnParamX
 //- FwdParamY influences DefnParamY
-//- // DefnFnF influences FwdFnF TODO(#4812)
+//- DefnFnF influences FwdFnF
 --------------------------------------------------------------------------------