Allow caller to provide RazorLightEngine #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed a quick fix to some tabs/spaces issues in FluentEmailRazorBuilderExtensions.cs, this file is a weird mix of tabs and spaces. let me know if I should just convert that whole file to spaces while I am in there. |
|
Hold off on accepting this for now. We need to support more than just For example, FluentEmail's |
|
This might not be needed since someone can call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we provide a bunch of convenience methods to build out an engine, but we never allow the user to provide their own.
There are a lot of options being added to the RazorLightEngineBuilder and instead of trying to add an extension for every possible scenario, it will be helpful to allow the caller to provide their own.