Added a dragging feature #229

darkomtc11 · 2019-09-24T15:14:55Z

Plain javascript implementation for dragging by holding the edges of modal or by handle with class ".draggable".

darkomtc11 · 2019-09-24T15:40:04Z

Known issues:

When multiple modal windows are opened, dragging one moves all of the opened modals.

maximelafarie · 2019-09-25T08:13:00Z

Hi @darkomtc11 and thank you for submitting us this PR. I'll take a look at:

When multiple modal windows are opened, dragging one moves all of the opened modals.

The team and I will check and test it, then we'll come back to you. 😉

Regards 🖖

BUG FIX: Multiple opened dragging modals will now move independently when being dragged.

For codeclimate issue fix

darkomtc11 · 2019-10-02T15:40:24Z

@maximelafarie Hey,
I have fixed the bug that occurred when dragging modal. It used to drag all of the opened modals, and now it is working properly.

maximelafarie · 2019-10-03T08:25:25Z

Thank you @darkomtc11! You did a great job! This is a really cool feature and it'll be a pleasure to release it! 🤓

The last thing to do is maybe to add some unit tests about position computing and error handling (if / else statements and callbacks) 🤔 @LouisAugry @marco10024 what do you think about it?

LouisAugry · 2019-10-03T08:43:55Z

We attach great importance to unit testing, as you can see on our 100% coverage badge. In order to keep our quality standard, can you implement unit tests please? Otherwise excellent work, and thank you very much for contributing ! 😉✌️

darkomtc11 · 2019-10-03T08:46:39Z

We attach great importance to unit testing, as you can see on our 100% coverage badge. In order to keep our quality standard, can you implement unit tests please? Otherwise excellent work, and thank you very much for contributing ! 😉✌️

Thanks!
I will try to hack something, since I haven't done unit testing before. :)

maximelafarie · 2019-10-03T08:59:38Z

I will try to hack something, since I haven't done unit testing before. :)

Feel free to inspire yourself from the existing unit tests, especially the tests on the modal "target placement" here 😉

Added 13 unit test methods for next methods: setPosition, moveDialog, startDrag, elementDrag, stopDrag

darkomtc11 · 2019-10-03T11:53:30Z

I will try to hack something, since I haven't done unit testing before. :)

Feel free to inspire yourself from the existing unit tests, especially the tests on the modal "target placement" here 😉

I have finished unit tests for my functions. All passing, all good, but since I have no experience with this, I advise you to check them in detail.
For example, I wasn't sure about .contains() function in nsmContent. (here)

src/ngx-smart-modal/src/components/ngx-smart-modal.component.ts

src/ngx-smart-modal/src/ngx-smart-modal.scss

src/ngx-smart-modal/tests/components/ngx-smart-modal.component.spec.ts

darkomtc11 · 2019-10-03T13:20:30Z

I have fixed all requested changes. I hope it is good now. If there's anything else, I will gladly hop in to change things.

Also, I don't know if it's supposed to work like that, but, after 'npm installing' in inner angular project (ngx-smart-modal), I cannot start outer (full) project. I think you might have some node_modules installed locally and they are maybe missing in package.json.
I always need to delete node_modules from inner project to start outer project.

src/ngx-smart-modal/src/components/ngx-smart-modal.component.ts

darkomtc11 · 2019-10-16T15:09:19Z

Is there anything else I can do to fasten up the process? I really need this feature. :D
I can create another pull request and make sure I DO NOT alter package-lock.json.

maximelafarie · 2019-11-29T15:22:21Z

There's merge conflicts 😕! Can @LouisAugry and @marco10024 take a look about the conflicts please?

LouisAugry · 2019-11-29T15:40:25Z

Conflicts are simple, only need to accept both sides and merge together the diffs

darkomtc11 · 2019-11-29T17:00:20Z

Conflicts are simple, only need to accept both sides and merge together the diffs

Done.

src/app/demo/main/main.component.scss

src/app/demo/main/main.component.html

src/ngx-smart-modal/src/components/ngx-smart-modal.component.ts

maximelafarie · 2019-12-03T15:24:56Z

@darkomtc11 I've let some review comments! We're not far from the release, hang on! 😉
You did an awesome work! 💪When you've fixed the rest, I'll merge your work and release a new version! 👌

darkomtc11 · 2019-12-23T00:03:09Z

@darkomtc11 I've let some review comments! We're not far from the release, hang on! 😉
You did an awesome work! 💪When you've fixed the rest, I'll merge your work and release a new version! 👌

I have done those, but there are package-lock conflicts. Do you have permission to resolve this? If not, tell me what to do exactly. 7.3.0 version has more packages than 7.2.1. I'm not sure which part of file should I take.

LouisAugry · 2019-12-26T12:07:31Z

Just remove the package-lock form your changes

LouisAugry · 2020-01-08T08:27:37Z

@darkomtc11 Build failed, can you resolve it please ? 😉After that I think we'll merge it !

Many thanks for your help and your contribution ✌️

vercel · 2020-02-03T08:13:21Z

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/biig/ngx-smart-modal/2fllc1124
✅ Preview: https://ngx-smart-modal-git-fork-darkomtc11-feature-draggable.biig.now.sh

maximelafarie · 2020-02-03T08:42:32Z

@darkomtc11 thank you for rebasing but I already done it locally. 😉 I removed the packages files changes and I'm now ready to merge it! Stay tuned! 🖖

Dunsteer · 2020-09-27T11:22:19Z

Any news?

darkomtc11 added 2 commits September 24, 2019 17:13

Added a dragging feature

478213c

Plain javascript implementation for dragging by holding the edges of modal or by handle with class ".draggable".

SCSS new line and bracket fix

d26f607

maximelafarie added effort2: medium (days) help wanted Testing The current code is being tested or should be tested Work In Progress This is a Work In Progress (WIP) labels Sep 25, 2019

darkomtc11 added 2 commits October 2, 2019 17:30

Improved dragging feature

af449b0

BUG FIX: Multiple opened dragging modals will now move independently when being dragged.

Simplifying if statement

f20dad9

For codeclimate issue fix

maximelafarie self-requested a review October 3, 2019 08:00

Refactoring dragging methods and unit tests.

ad0f44e

Added 13 unit test methods for next methods: setPosition, moveDialog, startDrag, elementDrag, stopDrag

maximelafarie requested a review from LouisAugry October 3, 2019 12:15

maximelafarie self-assigned this Oct 3, 2019

maximelafarie removed Work In Progress This is a Work In Progress (WIP) effort2: medium (days) help wanted labels Oct 3, 2019

LouisAugry requested changes Oct 3, 2019

View reviewed changes

Fixed requested changes

14aed23

darkomtc11 requested a review from LouisAugry October 3, 2019 13:45

Merge branch 'master' into feature/draggable

f6fe90e

LouisAugry requested changes Oct 3, 2019

View reviewed changes

src/ngx-smart-modal/src/components/ngx-smart-modal.component.ts Outdated Show resolved Hide resolved

New line in template for more visibility.

f2e1990

LouisAugry added this to the 2019 features milestone Oct 7, 2019

Merge branch 'master' into feature/draggable

22b0f0c

maximelafarie requested changes Dec 3, 2019

View reviewed changes

src/app/demo/main/main.component.scss Outdated Show resolved Hide resolved

src/app/demo/main/main.component.html Outdated Show resolved Hide resolved

src/ngx-smart-modal/src/components/ngx-smart-modal.component.ts Outdated Show resolved Hide resolved

darkomtc11 added 3 commits December 23, 2019 00:52

Added space where needed

3203ab5

Removed new line

2e5cb19

Removed new line.

85e96bf

Merge branch 'master' into feature/draggable

75dda4e

maximelafarie modified the milestones: 2019 features, v8 Release Jan 16, 2020

maximelafarie pushed a commit that referenced this pull request Jan 28, 2020

Removed modified files from pull request #229

90576a9

maximelafarie pushed a commit that referenced this pull request Jan 28, 2020

Fix code regression on mouse behavior (text selection) #229

0cdc1f7

maximelafarie pushed a commit that referenced this pull request Jan 29, 2020

Removed modified files from pull request #229

033952b

maximelafarie pushed a commit that referenced this pull request Jan 29, 2020

Fix code regression on mouse behavior (text selection) #229

a5b330f

Merge branch 'master' into feature/draggable

7fee944

vercel bot deployed to Preview February 3, 2020 08:12 View deployment

package-lock closed bracket

1968ffa

vercel bot deployed to Preview February 3, 2020 08:38 View deployment

maximelafarie pushed a commit that referenced this pull request Feb 21, 2020

Removed modified files from pull request #229

9c1602f

maximelafarie pushed a commit that referenced this pull request Feb 21, 2020

Fix code regression on mouse behavior (text selection) #229

621898b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a dragging feature #229

Added a dragging feature #229

darkomtc11 commented Sep 24, 2019

darkomtc11 commented Sep 24, 2019

maximelafarie commented Sep 25, 2019

darkomtc11 commented Oct 2, 2019 •

edited

Loading

maximelafarie commented Oct 3, 2019

LouisAugry commented Oct 3, 2019

darkomtc11 commented Oct 3, 2019

maximelafarie commented Oct 3, 2019

darkomtc11 commented Oct 3, 2019 •

edited

Loading

darkomtc11 commented Oct 3, 2019 •

edited

Loading

darkomtc11 commented Oct 16, 2019

maximelafarie commented Nov 29, 2019

LouisAugry commented Nov 29, 2019

darkomtc11 commented Nov 29, 2019

maximelafarie commented Dec 3, 2019

darkomtc11 commented Dec 23, 2019

LouisAugry commented Dec 26, 2019

LouisAugry commented Jan 8, 2020

vercel bot commented Feb 3, 2020 •

edited

Loading

maximelafarie commented Feb 3, 2020

Dunsteer commented Sep 27, 2020

Added a dragging feature #229

Are you sure you want to change the base?

Added a dragging feature #229

Conversation

darkomtc11 commented Sep 24, 2019

darkomtc11 commented Sep 24, 2019

maximelafarie commented Sep 25, 2019

darkomtc11 commented Oct 2, 2019 • edited Loading

maximelafarie commented Oct 3, 2019

LouisAugry commented Oct 3, 2019

darkomtc11 commented Oct 3, 2019

maximelafarie commented Oct 3, 2019

darkomtc11 commented Oct 3, 2019 • edited Loading

darkomtc11 commented Oct 3, 2019 • edited Loading

darkomtc11 commented Oct 16, 2019

maximelafarie commented Nov 29, 2019

LouisAugry commented Nov 29, 2019

darkomtc11 commented Nov 29, 2019

maximelafarie commented Dec 3, 2019

darkomtc11 commented Dec 23, 2019

LouisAugry commented Dec 26, 2019

LouisAugry commented Jan 8, 2020

vercel bot commented Feb 3, 2020 • edited Loading

maximelafarie commented Feb 3, 2020

Dunsteer commented Sep 27, 2020

darkomtc11 commented Oct 2, 2019 •

edited

Loading

darkomtc11 commented Oct 3, 2019 •

edited

Loading

darkomtc11 commented Oct 3, 2019 •

edited

Loading

vercel bot commented Feb 3, 2020 •

edited

Loading