From 3697786d4f12fa64cec5148a9ba06cb7a7339ff8 Mon Sep 17 00:00:00 2001 From: neilyoung Date: Mon, 14 Sep 2020 14:53:25 +0200 Subject: [PATCH] Prevent unnecessary "Unsupported codec 'none' error" (#2357) In case a party does not send audio, `audio_codec` renders `none`, which causes an unnecessary error in `janus_sdp_get_codec_rtpmap`. Because `do_audio` is already `false` at this time, it is checked and the call to `janus_sdp_get_codec_rtpmap` is prevented. Similar for video --- sdp-utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdp-utils.c b/sdp-utils.c index 033c6c2315..bf9b5aa7c5 100644 --- a/sdp-utils.c +++ b/sdp-utils.c @@ -1218,7 +1218,7 @@ janus_sdp *janus_sdp_generate_offer(const char *name, const char *address, ...) } if(audio_codec == NULL) audio_codec = "opus"; - const char *audio_rtpmap = janus_sdp_get_codec_rtpmap(audio_codec); + const char *audio_rtpmap = do_audio ? janus_sdp_get_codec_rtpmap(audio_codec) : NULL; if(do_audio && audio_rtpmap == NULL) { JANUS_LOG(LOG_ERR, "Unsupported audio codec '%s', can't prepare an offer\n", audio_codec); va_end(args); @@ -1234,7 +1234,7 @@ janus_sdp *janus_sdp_generate_offer(const char *name, const char *address, ...) } if(video_codec == NULL) video_codec = "vp8"; - const char *video_rtpmap = janus_sdp_get_codec_rtpmap(video_codec); + const char *video_rtpmap = do_video ? janus_sdp_get_codec_rtpmap(video_codec) : NULL; if(do_video && video_rtpmap == NULL) { JANUS_LOG(LOG_ERR, "Unsupported video codec '%s', can't prepare an offer\n", video_codec); va_end(args);