Merge pull request #4899 from NikCharlebois/Tests-Improvements

Improved performance of SPOSharingSettings
microsoft · Jul 17, 2024 · 973a908 · 973a908
2 parents f585c37 + da07b43
commit 973a908
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,8 @@
 * IntuneWindowsUpdateForBusinessQualityUpdateProfileWindows10
   * Initial release.  
     FIXES [#2659](https://github.com/microsoft/Microsoft365DSC/issues/2659)
+* SPOSharingSettings
+  * Improved performance by using -Filter on Get-PnPTenantSite calls.
 * M365DSCDRGUtil
   * Fixes an issue with nested and duplicate settings in the settings catalog
   * Add support for converting Intune assignments directly from Graph.  

diff --git a/Modules/Microsoft365DSC/DSCResources/MSFT_SPOSharingSettings/MSFT_SPOSharingSettings.psm1 b/Modules/Microsoft365DSC/DSCResources/MSFT_SPOSharingSettings/MSFT_SPOSharingSettings.psm1
@@ -173,7 +173,7 @@ function Get-TargetResource
     try
     {
         $SPOSharingSettings = Get-PnPTenant -ErrorAction Stop
-        $MySite = Get-PnPTenantSite | Where-Object { $_.Url -match '-my.sharepoint.' -and $_.Template -notmatch '^RedirectSite#' }
+        $MySite = Get-PnPTenantSite -Filter "Url -like '-my.sharepoint.' -and Template -notlike '^RedirectSite#'"
 
         if ($null -ne $MySite)
         {
@@ -532,7 +532,7 @@ function Set-TargetResource
     Set-PnPTenant @CurrentParameters | Out-Null
     if ($SetMySharingCapability)
     {
-        $mysite = Get-PnPTenantSite | Where-Object { $_.Url -match '-my.sharepoint.com/' -and $_.Template -notmatch '^RedirectSite#' }
+        $mysite = Get-PnPTenantSite -Filter "Url -like '-my.sharepoint.' -and Template -notlike '^RedirectSite#'"
         Set-PnPTenantSite -Identity $mysite.Url -SharingCapability $MySiteSharingCapability
     }
 }