Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PositionEncodingKind hook #270

Closed
tombh opened this issue Sep 14, 2023 · 2 comments · Fixed by #272
Closed

PositionEncodingKind hook #270

tombh opened this issue Sep 14, 2023 · 2 comments · Fixed by #272
Assignees

Comments

@tombh
Copy link

tombh commented Sep 14, 2023

Does this cattrs hook need to be added?

converter.register_structure_hook(
    Union[PositionEncodingKind, str, None], lambda obj, _: obj
)

I'm adding support for LSP 3.17's position encoding negotiation in Pygls and I was getting errors during server initialisation. The PR is here openlawlibrary/pygls#375

It's the first time I've come across this area of the codebase, so I'm not completely clear about what the best solution is.

@karthiknadig
Copy link
Member

I have added a new test suite that should catch all these issues.
#273

it adds significantly more coverage:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants