From b0726cf523c2322e0b72c08336984c488c3d6c33 Mon Sep 17 00:00:00 2001
From: yandeu <20306025+yandeu@users.noreply.github.com>
Date: Fri, 21 Jul 2023 17:19:29 +0200
Subject: [PATCH] Improve browser test

---
 scripts/browserTest/index.mjs           | 34 ++++++++++++++++++++++++-
 scripts/browserTest/mime.mjs            |  2 ++
 scripts/browserTest/nyc.mjs             |  2 ++
 scripts/browserTest/requestListener.mjs | 10 +++++---
 4 files changed, 43 insertions(+), 5 deletions(-)

diff --git a/scripts/browserTest/index.mjs b/scripts/browserTest/index.mjs
index a54297f..dadf971 100644
--- a/scripts/browserTest/index.mjs
+++ b/scripts/browserTest/index.mjs
@@ -1,3 +1,5 @@
+// @ts-check
+
 import crypto from 'crypto'
 import puppeteer from 'puppeteer'
 import { createServer } from 'http'
@@ -19,16 +21,46 @@ const ERROR_CODES = {
 let hasError = false
 
 const server = createServer(requestListener({ serve, collectCoverage }))
-server.closeAsync = () => new Promise(resolve => server.close(() => resolve()))
+server.closeAsync = () => /** @type {Promise<void>} */(new Promise(resolve => server.close(() => resolve())))
 
+/**
+ *  @param {{fileName:string, browser:puppeteer.Browser}} param0 
+ */
 const main = async ({ fileName, browser }) => {
   console.log(`> ${fileName}`)
 
   const page = await browser.newPage()
+  await page.setRequestInterception(true);
 
   // Enable both JavaScript and CSS coverage
   if (collectCoverage) await page.coverage.startJSCoverage()
 
+  /** @type {Array<puppeteer.HTTPRequest>} */
+  const requests = [];
+
+  // Blocks all window.location.href requests
+  page.on('request', async request => {
+    let isNavRequest = request.isNavigationRequest() && request.frame() === page.mainFrame();
+    if (!isNavRequest) {
+      request.continue();
+      return;
+    }
+
+    requests.push(request);
+    if (requests.length == 1) {
+      request.continue();
+      return;
+    }
+
+    request.abort('aborted');
+
+    const url = requests[requests.length - 1].url()
+    await page.evaluate((url) => {
+      window.__gotohref__ = url;
+    }, url);
+
+  });
+
   // Navigate to page
   let url = `http://localhost:8080/${fileName.replace(/^\+/, '')}`
   await page.goto(url, { waitUntil: 'networkidle2' })
diff --git a/scripts/browserTest/mime.mjs b/scripts/browserTest/mime.mjs
index d9d9ae6..9e2fa25 100644
--- a/scripts/browserTest/mime.mjs
+++ b/scripts/browserTest/mime.mjs
@@ -1,3 +1,5 @@
+// @ts-check
+
 import { extname } from 'path'
 
 export const mime = fileName => {
diff --git a/scripts/browserTest/nyc.mjs b/scripts/browserTest/nyc.mjs
index c88c185..a2b8ccb 100644
--- a/scripts/browserTest/nyc.mjs
+++ b/scripts/browserTest/nyc.mjs
@@ -1,3 +1,5 @@
+// @ts-check
+
 import { spawn } from 'child_process'
 
 const isWin = process.platform === 'win32'
diff --git a/scripts/browserTest/requestListener.mjs b/scripts/browserTest/requestListener.mjs
index dd01d55..b890dee 100644
--- a/scripts/browserTest/requestListener.mjs
+++ b/scripts/browserTest/requestListener.mjs
@@ -1,7 +1,8 @@
+// @ts-check
+
 import path from 'path'
 import { mime } from './mime.mjs'
 import { readFile } from 'fs/promises'
-import { spawn } from 'child_process'
 import { dirname, join } from 'path'
 import { fileURLToPath } from 'url'
 import { NYC } from './nyc.mjs'
@@ -13,12 +14,12 @@ const testerJS = await readFile(join(__dirname, './tester.js'), { encoding: 'utf
 
 export const totalPasses = [0, 0]
 
+/** @type {Array<{text:string, id: number, type?: string}>} */
 let _messages = []
+
 const sendMessages = () => {
   _messages
-    .sort((a, b) => {
-      a.id - b.id
-    })
+    .sort((a, b) => a.id - b.id)
     .forEach(m => {
       if (m.type === 'end') {
         const match = m.text.match(/(\d+)\/(\d+).passing/m)
@@ -39,6 +40,7 @@ const sendMessages = () => {
 
   _messages = []
 }
+
 const queueMessages = message => {
   _messages.push(message)