"nil dereference" when using DAX

[odannyc]

Description

When using DAX to query a dynamodb table and instrumenting the request with newrelic, I get a nil reference panic on this line:
https://github.com/newrelic/go-agent/blob/master/_integrations/nrawssdk/v1/nrawssdk.go#L28

internal.EndSegment(ctx, req.HTTPResponse.Header)

I stepped/debugged through a request and it looks like HTTPResponse is nil for DAX requests.

Steps to Reproduce

1. Create a dynamodb request
2. Instrument the handlers with the newrelic helper nrawssdk.InstrumentHandlers(&req.Handlers)
3. Send the request with DAX

Expected Behavior

Request sends without error and I see the trace in New Relic

NR Diag results

panic!

Your Environment

• github.com/newrelic/go-agent/v3/integrations/nrawssdk-v1 v1.0.0

Reproduction case

Additional context

[odannyc]

@RichVanderwal

Please let me know if there is any additional information you need.

Thank you.

[RichVanderwal]

Hi @odannyc , thanks for your patience here! You're on the short list of support issues for us to get back to, and we'll be taking a look at this soon.

[RichVanderwal]

After some review, we've decided to check for a nil value here and skip adding the AWS Request ID span attribute if there's no response. PR forthcoming!

[odannyc]

Hi @RichVanderwal ,

I have a PR open for this issue here:

#291

[RichVanderwal]

Hello @odannyc ! We've included your PR in the maintenance release of the Go Agent today. Let us know if you have any feedback, questions, or comments!