New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modal toggler and respect current url params when profiling #19

Open

Masa331 wants to merge 3 commits into peek:master from Masa331:master

Masa331 commented Oct 22, 2020

Hi there,

thanks for this wonderful gem

this pull requests adds 2 features to it

respects current page's url params. Until now page params were discarder(they were ignored when generating url with with :lineprofiler => true
adds simple modal toggler. When profiling is active, it adds hide/show toggler next to profiler link in Peek menu. This solves Feature request: close or hide button #10

happy to update the patch if you don't like something, just let me know

Masa331

Masa331 added 3 commits

October 22, 2020 09:23


          Add modal toggler

dc09a59


          Include current url params in profiler url

9bf928c


          Fix line skew due to double <pre> elements

674894b

Author

Masa331 commented Oct 22, 2020

Also added another commit which fixes this issue #18 which is due to code being wrapped in double <pre> tags and so having double padding around it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet