From 8b2b11cf125c612ce84545395ce028ba27683650 Mon Sep 17 00:00:00 2001 From: kirchsth Date: Sat, 4 May 2024 14:38:51 +0200 Subject: [PATCH] #349 $baseShape="label" uses correct color --- C4.puml | 13 ++++++++ LayoutOptions.md | 2 +- percy/TestAllPlantUmlElements.puml | 50 +++++++++++++++--------------- 3 files changed, 39 insertions(+), 26 deletions(-) diff --git a/C4.puml b/C4.puml index 42639f06..0bbc4f12 100644 --- a/C4.puml +++ b/C4.puml @@ -469,6 +469,19 @@ skinparam package { !$tagSkin = $tagSkin + $elementTagSkinparams("interface", $tagStereo, $bgColor, $bgColor, $borderColor, $shadowing, "", $borderStyle, $borderThickness) ' label uses wrong font color? (should be $bgColor too) !$tagSkin = $tagSkin + $elementTagSkinparams("label", $tagStereo, $bgColor, $bgColor, $borderColor, $shadowing, "", $borderStyle, $borderThickness) +' label colors cannot be set via skinparam use additional style + !$tagSkin = $tagSkin + "" + %newline() !endif $tagSkin !endprocedure diff --git a/LayoutOptions.md b/LayoutOptions.md index 7df4694c..8ac16e35 100644 --- a/LayoutOptions.md +++ b/LayoutOptions.md @@ -721,6 +721,7 @@ SHOW_LEGEND() | frame | ☑ | requires ENABLE_ALL_PLANT_ELEMENTS | | hexagon | ☑ | requires ENABLE_ALL_PLANT_ELEMENTS | | interface | ☑ | requires ENABLE_ALL_PLANT_ELEMENTS | +| label | ☑ | requires ENABLE_ALL_PLANT_ELEMENTS | | package | ☑ | requires ENABLE_ALL_PLANT_ELEMENTS | | stack | ☑ | requires ENABLE_ALL_PLANT_ELEMENTS | | storage | ☑ | requires ENABLE_ALL_PLANT_ELEMENTS | @@ -728,7 +729,6 @@ SHOW_LEGEND() | usecase/ | ☑ | requires ENABLE_ALL_PLANT_ELEMENTS | | | | | | actor/ | ❌ | requires ENABLE_ALL_PLANT_ELEMENTS, not working (font color not changed to $bkColor) - and/or conflict with existing? | -| label | ❌ | requires ENABLE_ALL_PLANT_ELEMENTS, not working (font color not changed to $bkColor) | If `ENABLE_ALL_PLANT_ELEMENTS` is not set, the diagrams displays the requested "PlantUML element" but the style is not correct. diff --git a/percy/TestAllPlantUmlElements.puml b/percy/TestAllPlantUmlElements.puml index 4e24888e..4717816c 100644 --- a/percy/TestAllPlantUmlElements.puml +++ b/percy/TestAllPlantUmlElements.puml @@ -83,30 +83,30 @@ Container(storageContainer, "Container storage", "storage", "A Container with st Container(usecaseContainer, "Container usecase", "usecase", "A Container with usecase element", $baseShape="usecase") Container(usecaseBCContainer, "Container usecase/", "usecase/", "A Container with usecase/ element", $baseShape="usecase/") -System(actorSystem, "System actor", "actor", "A System with actor element", $baseShape="actor") -System(actorBCSystem, "System actor/", "actor/", "A System with actor/ element", $baseShape="actor/") -System(agentSystem, "System agent", "agent", "A System with agent element", $baseShape="agent") -System(artifactSystem, "System artifact", "artifact", "A System with artifact element", $baseShape="artifact") -System(boundarySystem, "System boundary", "boundary", "A System with boundary element", $baseShape="boundary") -System(cardSystem, "System card", "card", "A System with card element", $baseShape="card") -System(circleSystem, "System circle", "circle", "A System with circle element", $baseShape="circle") -System(cloudSystem, "System cloud", "cloud", "A System with cloud element", $baseShape="cloud") -System(collectionsSystem, "System collections", "collections", "A System with collections element", $baseShape="collections") -System(controlSystem, "System control", "control", "A System with control element", $baseShape="control") -System(entitySystem, "System entity", "entity", "A System with entity element", $baseShape="entity") -System(fileSystem, "System file", "file", "A System with file element", $baseShape="file") -System(folderSystem, "System folder", "folder", "A System with folder element", $baseShape="folder") -System(frameSystem, "System frame", "frame", "A System with frame element", $baseShape="frame") -System(hexagonSystem, "System hexagon", "hexagon", "A System with hexagon element", $baseShape="hexagon") -System(interfaceSystem, "System interface", "interface", "A System with interface element", $baseShape="interface") -System(labelSystem, "System label", "label", "A System with label element", $baseShape="label") -System(nodeSystem, "System node", "node", "A System with node element", $baseShape="node") -System(packageSystem, "System package", "package", "A System with package element", $baseShape="package") -System(personSystem, "System person", "person", "A System with person element", $baseShape="person") -System(stackSystem, "System stack", "stack", "A System with stack element", $baseShape="stack") -System(storageSystem, "System storage", "storage", "A System with storage element", $baseShape="storage") -System(usecaseSystem, "System usecase", "usecase", "A System with usecase element", $baseShape="usecase") -System(usecaseBCSystem, "System usecase/", "usecase/", "A System with usecase/ element", $baseShape="usecase/") +System(actorSystem, "System actor", $type="actor", "A System with actor element", $baseShape="actor") +System(actorBCSystem, "System actor/", $type="actor/", "A System with actor/ element", $baseShape="actor/") +System(agentSystem, "System agent", $type="agent", "A System with agent element", $baseShape="agent") +System(artifactSystem, "System artifact", $type="artifact", "A System with artifact element", $baseShape="artifact") +System(boundarySystem, "System boundary", $type="boundary", "A System with boundary element", $baseShape="boundary") +System(cardSystem, "System card", $type="card", "A System with card element", $baseShape="card") +System(circleSystem, "System circle", $type="circle", "A System with circle element", $baseShape="circle") +System(cloudSystem, "System cloud", $type="cloud", "A System with cloud element", $baseShape="cloud") +System(collectionsSystem, "System collections", $type="collections", "A System with collections element", $baseShape="collections") +System(controlSystem, "System control", $type="control", "A System with control element", $baseShape="control") +System(entitySystem, "System entity", $type="entity", "A System with entity element", $baseShape="entity") +System(fileSystem, "System file", $type="file", "A System with file element", $baseShape="file") +System(folderSystem, "System folder", $type="folder", "A System with folder element", $baseShape="folder") +System(frameSystem, "System frame", $type="frame", "A System with frame element", $baseShape="frame") +System(hexagonSystem, "System hexagon", $type="hexagon", "A System with hexagon element", $baseShape="hexagon") +System(interfaceSystem, "System interface", $type="interface", "A System with interface element", $baseShape="interface") +System(labelSystem, "System label", $type="label", "A System with label element", $baseShape="label") +System(nodeSystem, "System node", $type="node", "A System with node element", $baseShape="node") +System(packageSystem, "System package", $type="package", "A System with package element", $baseShape="package") +System(personSystem, "System person", $type="person", "A System with person element", $baseShape="person") +System(stackSystem, "System stack", $type="stack", "A System with stack element", $baseShape="stack") +System(storageSystem, "System storage", $type="storage", "A System with storage element", $baseShape="storage") +System(usecaseSystem, "System usecase", $type="usecase", "A System with usecase element", $baseShape="usecase") +System(usecaseBCSystem, "System usecase/", $type="usecase/", "A System with usecase/ element", $baseShape="usecase/") -SHOW_LEGEND() +SHOW_LEGEND(false) @enduml \ No newline at end of file