From ddb66fd245265214e6333c4807046f4facc11517 Mon Sep 17 00:00:00 2001
From: Olivier <osazos@adagio.io>
Date: Tue, 14 May 2024 19:31:26 +0200
Subject: [PATCH] AdagioBidAdapter: validate `plcmt` video param () (#11487)

---
 modules/adagioBidAdapter.js                | 7 ++++++-
 test/spec/modules/adagioBidAdapter_spec.js | 4 ++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/modules/adagioBidAdapter.js b/modules/adagioBidAdapter.js
index 86f0b0e09e3..ac2e578de5c 100644
--- a/modules/adagioBidAdapter.js
+++ b/modules/adagioBidAdapter.js
@@ -64,7 +64,11 @@ export const ORTB_VIDEO_PARAMS = {
   'w': (value) => isInteger(value),
   'h': (value) => isInteger(value),
   'startdelay': (value) => isInteger(value),
-  'placement': (value) => isInteger(value),
+  'placement': (value) => {
+    logWarn(LOG_PREFIX, 'The OpenRTB video param `placement` is deprecated and should not be used anymore.');
+    return isInteger(value)
+  },
+  'plcmt': (value) => isInteger(value),
   'linearity': (value) => isInteger(value),
   'skip': (value) => [1, 0].includes(value),
   'skipmin': (value) => isInteger(value),
@@ -964,6 +968,7 @@ export const spec = {
 
     autoFillParams(bid);
 
+    // Note: `bid.params.placement` is not related to the video param `placement`.
     if (!(bid.params.organizationId && bid.params.site && bid.params.placement)) {
       logWarn(`${LOG_PREFIX} at least one required param is missing.`);
       // internal.enqueue(debugData());
diff --git a/test/spec/modules/adagioBidAdapter_spec.js b/test/spec/modules/adagioBidAdapter_spec.js
index 19ccb49eea1..b11c0ab4a8e 100644
--- a/test/spec/modules/adagioBidAdapter_spec.js
+++ b/test/spec/modules/adagioBidAdapter_spec.js
@@ -493,7 +493,7 @@ describe('Adagio bid adapter', () => {
             skipafter: 4,
             minduration: 10,
             maxduration: 30,
-            placement: 3,
+            plcmt: 4,
             protocols: [8]
           }
         }).build();
@@ -508,7 +508,7 @@ describe('Adagio bid adapter', () => {
           skipafter: 4,
           minduration: 10,
           maxduration: 30,
-          placement: 3,
+          plcmt: 4,
           protocols: [8],
           w: 300,
           h: 250