Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons color not working #6

Closed
MarinPostma opened this issue Nov 1, 2021 · 8 comments
Closed

Icons color not working #6

MarinPostma opened this issue Nov 1, 2021 · 8 comments
Assignees
Labels
assigned Under progress.

Comments

@MarinPostma
Copy link

Hello!

I am unsuccessfully trying to make to colored icons work, but nothing seems to work... Here is my config:

local fn = vim.fn
local install_path = fn.stdpath('data')..'/site/pack/packer/start/packer.nvim'
if fn.empty(fn.glob(install_path)) > 0 then
  packer_bootstrap = fn.system({'git', 'clone', '--depth', '1', 'https://github.com/wbthomason/packer.nvim', install_path})
end

return require('packer').startup(function(use)
	-- Theming
	use {
		'hoob3rt/lualine.nvim',
		config = function()
			require('lualine').setup {
				options = {
					theme = 'github'
				}
			}

		end
	}
	use {
		'projekt0n/github-nvim-theme',
		require = {"projekt0n/circles.nvim"},
		config = function()
			require("github-theme").setup({
				theme_style = "dark_default",
				function_style = "italic",
			})
		end
	}
	use {
		'lewis6991/gitsigns.nvim',
		requires = {
			'nvim-lua/plenary.nvim'
		},
		config = function() require('gitsigns').setup() end
	}
	use {
		"projekt0n/circles.nvim",
		requires = {{"kyazdani42/nvim-web-devicons"}, {"kyazdani42/nvim-tree.lua", opt = true}},
		config = function()
			require("circles").setup()
		end
	}
	use {
		'kyazdani42/nvim-tree.lua',
		config = function() require'nvim-tree'.setup {} end
	}

  if packer_bootstrap then
    require('packer').sync()
  end
end)

The coloring seems to work with web-dev-icons alone, and circles disabled.

@ful1e5
Copy link
Member

ful1e5 commented Nov 2, 2021

Can you able to share screenshots of the issue?

@ful1e5 ful1e5 self-assigned this Nov 2, 2021
@ful1e5 ful1e5 added the assigned Under progress. label Nov 2, 2021
@MarinPostma
Copy link
Author

sure, there you go:
image

@MarinPostma
Copy link
Author

Uhm no, that doesn't work, but if I disable the theme altogether, I get the colored circles. Maybe the issue comes from the theme?

@MarinPostma
Copy link
Author

I have forced the loading of circles and nvim-tree to occur before the them is loaded, without success:

	use {
		'projekt0n/github-nvim-theme',
		after = {
			'circles.nvim',
			'nvim-tree.lua',
		},
		config = function()
			require("github-theme").setup({
				theme_style = "dark_default",
				function_style = "italic",
			})
		end
	}

@erwinnp
Copy link

erwinnp commented Nov 12, 2021

I have same issue, how to fix it?

@ful1e5
Copy link
Member

ful1e5 commented Nov 12, 2021

Maybe the issue comes from the theme?

@MarinPostma Do you tried circles.nvim with other themes like tokyonight?

@MarinPostma
Copy link
Author

Sorry for responding sop late! I ended up changing my theme to https://github.com/catppuccin/nvim lately, and circle works like a charm. I suspect tokyonight might be the issue here.

@ful1e5
Copy link
Member

ful1e5 commented Dec 21, 2021

@MarinPostma You are correct. This issue is caused by a theme. It's working for me because I set my theme config outside the packer. You should try 🤞 the attached config until I managed to find the cause of this issue.

circles_nvim.mp4

plugins.lua

local fn = vim.fn
local install_path = fn.stdpath('data')..'/site/pack/packer/start/packer.nvim'
if fn.empty(fn.glob(install_path)) > 0 then
  packer_bootstrap = fn.system({'git', 'clone', '--depth', '1', 'https://github.com/wbthomason/packer.nvim', install_path})
end

local packer = require('packer').startup(function(use)
	-- Packer can manage itself
	use 'wbthomason/packer.nvim'
	-- Theming
	use {
		'hoob3rt/lualine.nvim',
		config = function()
			require('lualine').setup {
				options = {
					theme = 'github'
				}
			}
		end
	}
	use {
		'projekt0n/github-nvim-theme',
		require = {"projekt0n/circles.nvim"},
	}
	use {
		'lewis6991/gitsigns.nvim',
		requires = {
			'nvim-lua/plenary.nvim'
		},
		config = function() require('gitsigns').setup() end
	}
	use {
		"projekt0n/circles.nvim",
		requires = {{"kyazdani42/nvim-web-devicons"}, {"kyazdani42/nvim-tree.lua", opt = true}},
		config = function()
			require("circles").setup()
		end
	}
	use {
		'kyazdani42/nvim-tree.lua',
		config = function() require'nvim-tree'.setup {} end
	}

  if packer_bootstrap then
    require('packer').sync()
  end

  require("github-theme").setup({
	theme_style = "dark_default",
	function_style = "italic",
  })
end)


return packer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Under progress.
Projects
None yet
Development

No branches or pull requests

3 participants