bg_search & fg_search colors can't override

[jsgv]

After the latest updates my colors override options is not working anymore. It was working correctly yesterday.

require('github-theme').setup({
    theme_style = 'dimmed',
    colors = {
        bg_search = '#dae84d',
        fg_search = '#000000',
    }
})

Stopped working after doing a :PackerSync. Also noticed some other options were no longer being respected.

How it looks after :PackerSync:

[jsgv]

Works after reverting to older commit:

use {
    'projekt0n/github-nvim-theme',
    commit = '771ac5b'
}

Like I mentioned above, it also affects other options such as transparent and dark_float. My lua is not that strong so I'm sorry I can't contribute more.

[jsgv]

I tested the latest commit and I am still experiencing the same error. @ful1e5

[academo]

Something happened with the recent commits as well. I use transparent=true to keep my background black and with the latest update this is not respected.

I went back to the same commit 771ac5b you describe and it is back to work.

[jsgv]

Updated to latest. Looks like I can not change themes now:

require("github-theme").setup({
    theme_style = "light",
})

Above configuration stays dark.

[ful1e5]

@jsgv check #116

[thvdveld]

Also updated to the latest and cannot set the theme to dark_default. When setting it, the theme I get is dark, but not the dark_default one. (vim.o.background is set to dark)

[ful1e5]

create a new issue.

[thvdveld]

Will do! I maybe thought it had something to do with this, sorry for the trouble!