Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light theme not working #116

Closed
wongjiahau opened this issue Oct 18, 2021 · 3 comments · Fixed by #118
Closed

Light theme not working #116

wongjiahau opened this issue Oct 18, 2021 · 3 comments · Fixed by #118

Comments

@wongjiahau
Copy link

Steps to reproduce

  1. Install this plugin
  2. Paste the following in init.lua
require('github-theme').setup({
  theme_style = 'light_default',
})

Expect result

Neovim colorised with Github Light theme.

Actual result

Neovim colorised with Github Dark theme.

Git Bisect result

I found the culprit commit, 41f844a.

@ful1e5
Copy link
Member

ful1e5 commented Oct 18, 2021

set vim.o.background = "light" before theme setup.

@wongjiahau
Copy link
Author

@ful1e5 Thanks that works! Would you update the README to include this?

ful1e5 added a commit to ful1e5/github-nvim-theme that referenced this issue Oct 18, 2021
@ful1e5
Copy link
Member

ful1e5 commented Oct 18, 2021

I added note inside README.md#configuration section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants