Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme config exemple is wrong! #134

Closed
gabrielDpadua21 opened this issue Nov 12, 2021 · 3 comments · Fixed by #135
Closed

Readme config exemple is wrong! #134

gabrielDpadua21 opened this issue Nov 12, 2021 · 3 comments · Fixed by #135

Comments

@gabrielDpadua21
Copy link

This exemplo in readme is not workin because forget the ' in object

Error

" Example config in VimScript " NOTE: Configuration needs to be set BEFORE loading the color scheme withcolorscheme` command
let g:github_function_style = "italic"
let g:github_sidebars = ["qf", "vista_kind", "terminal", "packer"]

" Change the "hint" color to the "orange" color, and make the "error" color bright red
let g:github_colors = {
\ 'hint: 'orange',
\ 'error': '#ff0000'
\ }

" Load the colorscheme
colorscheme github_dark
`

Work
" Example config in VimScript " NOTE: Configuration needs to be set BEFORE loading the color scheme withcolorscheme` command
let g:github_function_style = "italic"
let g:github_sidebars = ["qf", "vista_kind", "terminal", "packer"]

" Change the "hint" color to the "orange" color, and make the "error" color bright red
let g:github_colors = { 'hint': 'orange', 'error': '#ff0000'}

" Load the colorscheme
colorscheme github_dark
`

@ful1e5
Copy link
Member

ful1e5 commented Nov 16, 2021

I can't see the difference in both configs.

@gabrielDpadua21
Copy link
Author

gabrielDpadua21 commented Nov 16, 2021

Missing the ' in hint attribute in github_colors object when you run de config get a error message.

ful1e5 added a commit to ful1e5/github-nvim-theme that referenced this issue Nov 17, 2021
@ful1e5
Copy link
Member

ful1e5 commented Nov 17, 2021

Thanks, @gabrielDpadua21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants