Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes seems to be broken #160

Closed
nikitastupin opened this issue Jan 21, 2022 · 6 comments
Closed

Themes seems to be broken #160

nikitastupin opened this issue Jan 21, 2022 · 6 comments

Comments

@nikitastupin
Copy link

Hi 👋 Thank you for the project! I decided to try it but unfortunately faced the problem.

github_light looks like this:

Screenshot 2022-01-22 at 00 19 42

github_dark even worse:

Screenshot 2022-01-22 at 00 20 17

% nvim --version
NVIM v0.6.1
% cat ~/.config/nvim/init.vim 
set number
set relativenumber

call plug#begin()
Plug 'projekt0n/github-nvim-theme'
call plug#end()

colorscheme github_light

I'm running nvim under Ubuntu Server VM.

Any ideas why the theme works that way?

@ful1e5 ful1e5 added the help wanted Extra attention is needed label Jan 22, 2022
@haunt98
Copy link

haunt98 commented Jan 27, 2022

I seem to experience the samething. I use neovim in termux over ssh in Terminal.app (macOS)

image

My init.vim

When I use kitty, it seems fine.

image

@Maksimka101
Copy link

Looks like your terminal doesn't support some advanced colours. I had the same problems so I moved from default mac terminal to iterm and now it works fine

@negz
Copy link

negz commented Mar 31, 2022

I have the same problem in the default Mac Terminal.app - but weirdly not when I use tmux inside Terminal.app. 🤔 In Terminal.app TERM=xterm-256color, whereas in tmux TERM=screen-256color. I tried export TERM=screen-256color in "plain" Terminal.app without success.

@qinyuhang
Copy link

I have the same issue here. Is this a bug of macOS's default Terminal.app? Any one has an idea of workaround?

@UrsaDK
Copy link

UrsaDK commented Nov 16, 2022

To add to what @Maksimka101 has already said: the palette for this colour scheme is defined using hex RGB notations (eg: #e1e4e8), which means that the terminal you use needs to support true colours. The colour palette for Apple's default Terminal.app only supports 256 colours (1, 2, 3, 4). Thus, it simply can not display all the colours defined by this colour scheme.

Why does it works in tmux? - Because tmux is essentially a terminal emulator. It works by translating the features of your actual terminal into an (often different) internal terminal. To put it simply, it duplicates your terminal's ability to draw characters and show colours, but tmux does it using newer libraries. :)

Related notes:

@ful1e5
Copy link
Member

ful1e5 commented May 5, 2023

Closing due to inactivity. Can reopen later.

@ful1e5 ful1e5 closed this as completed May 5, 2023
@ful1e5 ful1e5 removed the help wanted Extra attention is needed label May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants