Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set foreground colour for Diff* groups? #182

Closed
tombh opened this issue May 28, 2022 · 1 comment
Closed

Don't set foreground colour for Diff* groups? #182

tombh opened this issue May 28, 2022 · 1 comment
Assignees
Labels
assigned Under progress. enhancement New feature or request Planned Part of a project
Projects

Comments

@tombh
Copy link

tombh commented May 28, 2022

I just installed the Diffview plugin and noticed that syntax highlighting was being overwritten by the Diff* groups. With this override I got the syntax highlighting back and tidied up the diff-changed colours:

overrides = function(c)
  return {
    DiffAdd = {
      bg = c.diff.add,
    },
    DiffChange = {},
    DiffDelete = {
      bg = c.diff.delete,
    },
    DiffText = { bg = c.diff.change },
  }
end,

Edit: added link to Diffview plugin

@luisdavim
Copy link
Contributor

@tombh could you maybe open a PR for this?

@ful1e5 ful1e5 added the enhancement New feature or request label Jun 10, 2022
@ful1e5 ful1e5 self-assigned this Jun 10, 2022
@ful1e5 ful1e5 added this to To do in Workboard via automation Jun 10, 2022
@ful1e5 ful1e5 added assigned Under progress. Planned Part of a project labels Jun 10, 2022
@ful1e5 ful1e5 moved this from To do to In progress in Workboard Jun 10, 2022
@ful1e5 ful1e5 closed this as completed in fa43c31 Jun 10, 2022
Workboard automation moved this from In progress to Done Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Under progress. enhancement New feature or request Planned Part of a project
Projects
Development

No branches or pull requests

3 participants